Testing rework: .ToObservableChangeSet()
#760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…increasting code coverage from 69% to 100% across the internal implementation classes. Identified existing defects within the `.ToObservableChangeSet()` operators, mostly related to error and completion propagation, and implemented testing for this behavior, with the tests being marked as "Skip" until the defects are fixed. This also includes the defect referred in reactivemarbles#635. Added an `IsCompleted` flag to `ChangeSetAggregator<T>`, to allow for testing of completion propagation.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
==========================================
+ Coverage 64.74% 65.55% +0.80%
==========================================
Files 226 227 +1
Lines 11459 11095 -364
Branches 2334 2294 -40
==========================================
- Hits 7419 7273 -146
+ Misses 3083 2884 -199
+ Partials 957 938 -19 ☔ View full report in Codecov by Sentry. |
|
|
||
| [Fact(Skip = "Outstanding bug, completion is not forwarded")] | ||
| [System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "xUnit1004:Test methods should not be skipped", Justification = "Bug to be fixed")] | ||
| public void RemovalsArePending_CompletionWaitsForRemovals() |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuilt test fixtures for both
.ToObservableChangeSet()operators, increasting code coverage from 69% to 100% across the internal implementation classes.Identified existing defects within the
.ToObservableChangeSet()operators, mostly related to error and completion propagation, and implemented testing for this behavior, with the tests being marked as "Skip" until the defects are fixed. This also includes the defect referred in #635.Added an
IsCompletedflag toChangeSetAggregator<T>, to allow for testing of completion propagation.