Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The hex_digits function is broken on ARM32 builds #51

Closed
markaylett opened this issue Oct 8, 2019 · 0 comments · Fixed by #52
Closed

The hex_digits function is broken on ARM32 builds #51

markaylett opened this issue Oct 8, 2019 · 0 comments · Fixed by #52
Labels
bug Something isn't working
Milestone
Release: 0.5.0

Comments

@markaylett
Copy link
Collaborator 

Running 199 test cases...
toolbox/toolbox/util/Utility.ut.cpp(135): error: in "UtilitySuite/HexDigitsCase": check hex_digits(0x0) == 1 has failed [9 != 1]
toolbox/toolbox/util/Utility.ut.cpp(136): error: in "UtilitySuite/HexDigitsCase": check hex_digits(0x1) == 1 has failed [9 != 1]
toolbox/toolbox/util/Utility.ut.cpp(137): error: in "UtilitySuite/HexDigitsCase": check hex_digits(0xf) == 1 has failed [9 != 1]
toolbox/toolbox/util/Utility.ut.cpp(138): error: in "UtilitySuite/HexDigitsCase": check hex_digits(0x10) == 2 has failed [10 != 2]
toolbox/toolbox/util/Utility.ut.cpp(139): error: in "UtilitySuite/HexDigitsCase": check hex_digits(0xff) == 2 has failed [10 != 2]
toolbox/toolbox/util/Utility.ut.cpp(141): error: in "UtilitySuite/HexDigitsCase": check hex_digits(0xcdef) == 4 has failed [12 != 4]
toolbox/toolbox/util/Utility.ut.cpp(142): error: in "UtilitySuite/HexDigitsCase": check hex_digits(0x10000) == 5 has failed [13 != 5]
toolbox/toolbox/util/Utility.ut.cpp(143): error: in "UtilitySuite/HexDigitsCase": check hex_digits(0x89abcdef) == 8 has failed [16 != 8]
toolbox/toolbox/util/Utility.ut.cpp(145): error: in "UtilitySuite/HexDigitsCase": check hex_digits(0x567890abcdef) == 12 has failed [16 != 12]
toolbox/toolbox/util/Utility.ut.cpp(146): error: in "UtilitySuite/HexDigitsCase": check hex_digits(0x1000000000000) == 13 has failed [9 != 13]
Oct 08 06:43:14.661 NOTICE  [6857]: started resolver thread
Oct 08 06:43:14.662 NOTICE  [6857]: stopping resolver thread

*** 10 failures are detected in the test module "Master Test Suite"
@markaylett markaylett added the bug Something isn't working label Oct 8, 2019
@markaylett markaylett added this to the Release: 0.5.0 milestone Oct 8, 2019
markaylett added a commit to markaylett/toolbox-cpp that referenced this issue Oct 20, 2019
@markaylett
bug: the hex_digits function is broken on ARM32 builds
ecb35bf 
The hex_digits function was using the long version of the bultin clz
function (__builtin_clzl). Long integers are 32-bits on ARM32. A
function template has been added to ensure that the correct intrinsic
is used in future based on the size of the integer type.

Closes reactivemarkets#51
@markaylett markaylett mentioned this issue Oct 20, 2019
Merged
markaylett added a commit to markaylett/toolbox-cpp that referenced this issue Oct 20, 2019
@markaylett
bug: the hex_digits function is broken on ARM32 builds
74e25cb 
The hex_digits function was using the long version of the bultin clz
function (__builtin_clzl). Long integers are 32-bits on ARM32. A
function template has been added to ensure that the correct intrinsic
is used in future based on the size of the integer type.

Closes reactivemarkets#51
markaylett added a commit that referenced this issue Oct 20, 2019
@markaylett
bug: the hex_digits function is broken on ARM32 builds
d8f2755 
The hex_digits function was using the long version of the bultin clz
function (__builtin_clzl). Long integers are 32-bits on ARM32. A
function template has been added to ensure that the correct intrinsic
is used in future based on the size of the integer type.

Closes #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
Release: 0.5.0
Development

Successfully merging a pull request may close this issue.

bug: the hex_digits function is broken on ARM32 builds markaylett/toolbox-cpp
1 participant
@markaylett