Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type constructor on default from_string #96

Closed
rfernandes opened this issue Jun 18, 2020 · 0 comments · Fixed by #97
Closed

Use type constructor on default from_string #96

rfernandes opened this issue Jun 18, 2020 · 0 comments · Fixed by #97

Comments

@rfernandes
Copy link
Contributor

The common case of TypeTraits::from_string should use the target type's constructor, this removes the need to specialize it for those that support String-type constructors, ex: Path.
rfernandes added a commit to rfernandes/toolbox-cpp that referenced this issue Jun 18, 2020
@rfernandes
feat: Default from_string tries type constructor
cd3c2c4 
The common case of TypeTraits::from_string should use the target type's
constructor, this removes the need to specialize it for those that
support String-type constructors, ex: Path.

Removing Path files also removes the last "experimental" header

Closes reactivemarkets#96
@rfernandes rfernandes mentioned this issue Jun 18, 2020
Merged
rfernandes added a commit to rfernandes/toolbox-cpp that referenced this issue Jun 18, 2020
@rfernandes
feat: Default from_string tries type constructor
d7e16f7 
The common case of TypeTraits::from_string should use the target type's
constructor, this removes the need to specialize it for those that
support String-type constructors, ex: Path.

Removing Path files also removes the last "experimental" header

Closes reactivemarkets#96
rfernandes added a commit to rfernandes/toolbox-cpp that referenced this issue Jun 18, 2020
@rfernandes
feat: Default from_string tries type constructor
a3e9272 
The common case of TypeTraits::from_string should use the target type's
constructor, this removes the need to specialize it for those that
support String-type constructors, ex: Path.

Removing Path files also removes the last "experimental" header

Closes reactivemarkets#96
markaylett pushed a commit that referenced this issue Jun 18, 2020
@rfernandes @markaylett
feat: Default from_string tries type constructor
94d02e4 
The common case of TypeTraits::from_string should use the target type's
constructor, this removes the need to specialize it for those that
support String-type constructors, ex: Path.

Removing Path files also removes the last "experimental" header

Closes #96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Default from_string tries type constructor rfernandes/toolbox-cpp
1 participant
@rfernandes