Improve socket option support #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new `on_sock_init` lifecycle callback, so that applications are given an opportunity to set socket options such as `SO_RCVBUF` and `SO_SNDBUF`. This change also includes refactoring to make callback naming conventions clearer and more consistent. Closes reactivemarkets#35
markaylett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
on_sock_initlifecycle callback, so that applications are given an opportunity to set socket options such asSO_RCVBUFandSO_SNDBUF.This change also includes refactoring to make callback naming conventions clearer and more consistent.
Closes #35