Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw ObjectDisposedException and ArgumentNullException synchronously #286

Open
flagbug opened this issue May 18, 2016 · 0 comments
Open

Throw ObjectDisposedException and ArgumentNullException synchronously #286

flagbug opened this issue May 18, 2016 · 0 comments

Comments

@flagbug
Copy link
Member

flagbug commented May 18, 2016

Severe exceptions like ObjectDisposedExceptions and AgumentNullException shouldn't OnError the observable, and should rather be thrown immediately/synchronously.

See https://github.com/akavache/Akavache/blob/master/Akavache.Sqlite3/SqlitePersistentBlobCacheNext.cs#L63 for an example where they are passed via OnError
@flagbug flagbug mentioned this issue May 24, 2016
Merged
7 tasks
@ghuntley ghuntley mentioned this issue Sep 20, 2016
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flagbug