Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Akavache 5.0 Discussion #291

Merged
merged 17 commits into from
Nov 4, 2016
Merged

Ship Akavache 5.0 Discussion #291

merged 17 commits into from
Nov 4, 2016

Conversation

flagbug
Copy link
Member

@flagbug flagbug commented May 24, 2016

Done:

Next:

  • Retire MakeRelease.ps1 as it doesn't work anymore.
  • Resolve packaging story
  • Verify all references to SQLitePCLRaw.bundle_green are removed from nuspec (Geoff missed that in the last PR)
  • Build Xamarin.Mac on Windows

-> THEN RELEASE.

@ghuntley ghuntley changed the title Ship Akavache 5.0 Ship Akavache 6.0 Sep 20, 2016
@ghuntley ghuntley changed the title Ship Akavache 6.0 Ship Akavache 5.0 Sep 20, 2016
@ghuntley
Copy link
Member

ghuntley commented Sep 21, 2016

👋 @ericsink. That merge was house-keeping. I've read your notes am literately right now searching for a good insertion point for SQLitePCL.Batteries.Init();.

Current thoughts are to change the dependency to SQLitePCLRaw.bundle_e_sqlite3 (i.e. ship sqlite.so for all platforms) rather than SQLitePCLRaw.bundle_green (ship sqlite.so on all platforms except for iOS which uses OS version).

@flagbug @paulcbetts guidance would be appreciated.

@ericsink
Copy link
Contributor

:-)

Looking more at Akavache...

A PCL need only reference SQLitePCLRaw.core.

The bundle and the batteries Init call need to happen from the platform
code, because that's where stuff gets hooked up to the native bits.

Hope this all makes sense. I'm typing on a phone.

Using bundle e_sqlite3 makes sense to me. I personally like the consistency
of having the same SQLite lib on all platforms.

E

On Tuesday, September 20, 2016, Geoffrey Huntley notifications@github.com
wrote:

👋 @ericsink https://github.com/ericsink I've read your notes am
literately right now trying to find a good insertion point for
SQLitePCL.Batteries.Init();.

Current thoughts are to change the dependency to
SQLitePCLRaw.bundle_e_sqlite3 (i.e. ship sqlite.so for all platforms) vs
SQLitePCLRaw.bundle_green (ship sqlite.so on all platforms except for iOS
which uses OS version).

@flagbug https://github.com/flagbug @paulcbetts
https://github.com/paulcbetts guidance would be appreciated.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#291 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADsojT8yDAtzF2OBDupPUS3VCeIp0RDaks5qsHlpgaJpZM4Ill4C
.

ghuntley and others added 5 commits September 22, 2016 20:18
BREAKING CHANGE: Xamarin.Monotouch has been deprecated by Xamarin
BREAKING CHANGE: Xamarin.MonoMac has been deprecated by Xamarin
…317)

See:
- http://ericsink.com/entries/sqlite_android_n.html and 
- #317 (comment)
- #314

BREAKING CHANGE: major dependency changes SQLitePCL.raw_basic replaced by SQLitePCLRaw.bundle_e_sqlite3
@ghuntley
Copy link
Member

ghuntley commented Oct 13, 2016

RELEASE NOTES:

https://github.com/akavache/Akavache/blob/akavache5-master/RELEASENOTES.md

NuGet V3 Feed:

https://www.myget.org/F/akavache/api/v3/index.json

NuGet V2 Feed:

https://www.myget.org/F/akavache/api/v2

This needs to be tested on actual devices for each platform before release, if you spot a defect please PR it into this branch and once merged the updated package will be automatically published to MyGet.

Here's what I've tested; won't be in a position to test other platforms on real devices for a week or so.

  • NET45
  • UWP
  • iOS
  • Android

@PureWeen
Copy link
Collaborator

I have version "5.0.0.1476383622" from myget running on physical iOS and Android devices and haven't had any issues so far.

@flagbug
Copy link
Member Author

flagbug commented Oct 27, 2016

Hm, I updated to the latest prerelease, but I'm still getting the exception System.DllNotFoundException: /system/lib/libsqlite.so when calling BlobCache.Secure. Investigating...

@Qonstrukt
Copy link
Member

Did you manually remove the old SQLitePCL.raw_basic 0.8.6 package? Because this doesn't happen automatically when upgrading. At least not in XS.

@flagbug
Copy link
Member Author

flagbug commented Oct 27, 2016

Did you manually remove the old SQLitePCL.raw_basic 0.8.6 package? Because this doesn't happen automatically when upgrading. At least not in XS.

Aha! I still had an old version of sqlite-net-pcl installed. Updated it and now it works!

@flagbug
Copy link
Member Author

flagbug commented Oct 27, 2016

@ghuntley The CI seems to be flaky

@kjeremy
Copy link
Contributor

kjeremy commented Nov 3, 2016

I see no regressions in my Android and WPF application.

@ghuntley ghuntley added this to the 5.0.0 milestone Nov 4, 2016
@ghuntley ghuntley changed the title Ship Akavache 5.0 Ship Akavache 5.0 Discussion Nov 4, 2016
@ghuntley ghuntley mentioned this pull request Nov 4, 2016
@ghuntley ghuntley merged commit 501b397 into master Nov 4, 2016
@ghuntley ghuntley deleted the akavache5-master branch November 4, 2016 15:58
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants