Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Update Splat v7.* #472

Merged
merged 2 commits into from
Mar 23, 2019
Merged

housekeeping: Update Splat v7.* #472

merged 2 commits into from
Mar 23, 2019

Conversation

RLittlesII
Copy link
Member

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Upgrades Splat to v7.*

What is the current behavior? (You can also link to an open issue here)

Splat is on v6.*

What is the new behavior (if this is a feature change)?

Splat is on v7.*

Does this PR introduce a breaking change?

No. It does change platform registrations for Akavache against Splat.

Please check if the PR fulfills these requirements

Other information:

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #472 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   55.86%   55.86%           
=======================================
  Files          56       56           
  Lines        3353     3353           
  Branches      499      499           
=======================================
  Hits         1873     1873           
  Misses       1345     1345           
  Partials      135      135
Impacted Files Coverage Δ
src/Akavache/Registrations.cs 50% <ø> (ø) ⬆️
src/Akavache.Sqlite3/Registrations.cs 80% <ø> (ø) ⬆️
...rc/Akavache.Core/Platforms/shared/Registrations.cs 100% <ø> (ø) ⬆️
....Sqlite3/SqlLiteCache/SqlRawPersistentBlobCache.cs 80% <0%> (ø) ⬆️
...kavache.Sqlite3/Operations/SqliteOperationMixin.cs 28.57% <0%> (ø) ⬆️
src/Akavache.Core/BlobCache/InMemoryBlobCache.cs 57.22% <0%> (ø) ⬆️
src/Akavache.Core/Platforms/shared/Utility.cs 23.86% <0%> (ø) ⬆️
src/Akavache.Core/DependencyResolverMixin.cs 90.9% <100%> (ø) ⬆️
src/Akavache.Core/BlobCache/BlobCache.cs 26.98% <100%> (ø) ⬆️
...avache.Core/KeyedOperations/KeyedOperationQueue.cs 52.85% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a1a81...89b30b6. Read the comment docs.

@glennawatson glennawatson mentioned this pull request Mar 21, 2019
@RLittlesII
Copy link
Member Author

@glennawatson This test passes for me locally in visual studio, and running the build script. Am I missing something obvious?

@glennawatson glennawatson merged commit 28f0c6d into master Mar 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the splat7 branch March 23, 2019 01:57
@lock lock bot locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants