Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off xunit shadowCopy #496

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@ericsink
Copy link
Contributor

commented Aug 5, 2019

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This is a way to fix the problems with the xunit tests running under net461 with SQLitePCLRaw 2.0.

What is the current behavior? (You can also link to an open issue here)

An attempt to update the SQLitePCLRaw dependency to 2.0 caused problems with the xunit tests running under net461. I've generally found xunit with .NET Framework to be problematic for SQLitePCLRaw. Turning off shadowCopy has been an effective solution before.

See xunit/xunit#1198 for a bit more info.

What is the new behavior (if this is a feature change)?

The tests now run, on my machine anyway.

Does this PR introduce a breaking change?

I hope not.

Please check if the PR fulfills these requirements

Other information:

…1 with SQLitePCLRaw 2.0. turn off shadowCopy for xunit.
@dnfclas

This comment has been minimized.

Copy link

commented Aug 5, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

ericsink sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@ericsink

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

Note that I am seeing intermittent failures of FetchFunctionShouldBeCalledOnceForGetOrFetchObject. Not consistently. Just sometimes.

Was this happening before?

@glennawatson glennawatson merged commit 3f38977 into reactiveui:master Aug 6, 2019
0 of 2 checks passed
0 of 2 checks passed
Akavache-CI Build #6.5.32+4800f6e039 had test failures
Details
license/cla Contributor License Agreement is not signed yet.
Details
@glennawatson

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

I think I seen it happen yeah. I'm going to commit this change in and then fix the unit test. Thanks for helping out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.