turn off xunit shadowCopy #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1 with SQLitePCLRaw 2.0. turn off shadowCopy for xunit.
|
|
|
Note that I am seeing intermittent failures of Was this happening before? |
|
I think I seen it happen yeah. I'm going to commit this change in and then fix the unit test. Thanks for helping out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This is a way to fix the problems with the xunit tests running under net461 with SQLitePCLRaw 2.0.
What is the current behavior? (You can also link to an open issue here)
An attempt to update the SQLitePCLRaw dependency to 2.0 caused problems with the xunit tests running under net461. I've generally found xunit with .NET Framework to be problematic for SQLitePCLRaw. Turning off shadowCopy has been an effective solution before.
See xunit/xunit#1198 for a bit more info.
What is the new behavior (if this is a feature change)?
The tests now run, on my machine anyway.
Does this PR introduce a breaking change?
I hope not.
Please check if the PR fulfills these requirements
Other information: