Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping Update packages Fix build #814

Merged
merged 1 commit into from Nov 6, 2022

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Fix Update

What is the current behaviour?

Xamarin.Mac lib missing
Null issue

What is the new behaviour?

Added hintpath for Xamarin.Mac
Updated packages
added null checks

What might this PR break?

none expected

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@glennawatson glennawatson enabled auto-merge (squash) November 6, 2022 09:02
@glennawatson glennawatson merged commit 4432fe9 into main Nov 6, 2022
@glennawatson glennawatson deleted the CP_FixBuildUpdatePackages branch November 6, 2022 09:03
var rp = url.RelativePath;
if (rp == null)
{
throw new DirectoryNotFoundException();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a constructor with the path?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 30 - 36 all use enums to pass to this, I tried url?.RelativePath! but it still failed to compile

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Base: 58.15% // Head: 58.15% // No change to project coverage 👍

Coverage data is based on head (8a2ed9f) compared to base (865b438).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   58.15%   58.15%           
=======================================
  Files          59       59           
  Lines        3348     3348           
=======================================
  Hits         1947     1947           
  Misses       1401     1401           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants