Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Add Net 8.0 #876

Merged
merged 8 commits into from
Nov 25, 2023
Merged

Feature : Add Net 8.0 #876

merged 8 commits into from
Nov 25, 2023

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Feature

What is the current behavior?

Net 8.0 target not included

What is the new behavior?

Net 8.0 target included
Code cleanup

What might this PR break?

None expected

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (1ff9fba) 51.53% compared to head (77d18fb) 61.05%.
Report is 1 commits behind head on main.

Files Patch % Lines
...kavache.Core/Platforms/shared/AkavacheHttpMixin.cs 30.00% 7 Missing ⚠️
src/Akavache.Core/LoginInfo.cs 0.00% 3 Missing ⚠️
src/Akavache.Core/Platforms/shared/Utility.cs 0.00% 3 Missing ⚠️
src/Akavache.Core/BlobCache/InMemoryBlobCache.cs 50.00% 1 Missing ⚠️
src/Akavache.Core/Platforms/shared/StreamMixins.cs 0.00% 1 Missing ⚠️
...ite3/Operations/BeginTransactionSqliteOperation.cs 0.00% 1 Missing ⚠️
...he.Sqlite3/Operations/BulkInsertSqliteOperation.cs 0.00% 1 Missing ⚠️
...qlite3/Operations/BulkInvalidateSqliteOperation.cs 0.00% 1 Missing ⚠️
...he.Sqlite3/Operations/BulkSelectSqliteOperation.cs 0.00% 1 Missing ⚠️
...te3/Operations/CommitTransactionSqliteOperation.cs 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
+ Coverage   51.53%   61.05%   +9.51%     
==========================================
  Files          59       58       -1     
  Lines        3349     2321    -1028     
  Branches      588      363     -225     
==========================================
- Hits         1726     1417     -309     
+ Misses       1394      733     -661     
+ Partials      229      171      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman merged commit 46a4835 into main Nov 25, 2023
3 checks passed
@ChrisPulman ChrisPulman deleted the CP_AddNet8_0 branch November 25, 2023 06:05
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants