Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change so that if a event matches the standard event pattern #17

Merged
merged 3 commits into from Jun 14, 2019

Conversation

glennawatson
Copy link
Contributor

Clean up code to use 'using static' to avoid a lot of prefixes

…turn only value

Clean up code to use 'using static' to avoid a lot of prefixes
@glennawatson glennawatson requested a review from a team June 14, 2019 12:39
@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #17 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   83.26%   83.38%   +0.11%     
==========================================
  Files          36       36              
  Lines        1028     1029       +1     
  Branches      186      186              
==========================================
+ Hits          856      858       +2     
  Misses        148      148              
+ Partials       24       23       -1
Impacted Files Coverage Δ
...st.Core/Generation/Generators/DelegateGenerator.cs 100% <100%> (ø) ⬆️
...acist.Core/Generation/RoslynGeneratorExtensions.cs 97.67% <100%> (+2.32%) ⬆️
...Core/Generation/Generators/StaticEventGenerator.cs 100% <100%> (ø) ⬆️
...re/Generation/Generators/InstanceEventGenerator.cs 100% <100%> (ø) ⬆️
...t.Core/Generation/Generators/EventGeneratorBase.cs 97.05% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ae554...365f441. Read the comment docs.

@glennawatson glennawatson merged commit e8f09a4 into master Jun 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the glennawatson-bring-back-value-only branch June 14, 2019 12:59
@lock lock bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant