Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WinformsDemo] fix windows forms demo2 DataBinding incompatable data type #532

Merged
merged 6 commits into from Mar 16, 2022

Conversation

rallets
Copy link
Contributor

@rallets rallets commented Mar 16, 2022

What kind of change does this PR introduce?

Fix a "Complex DataBinding accepts as a data source either an IList or an IListSource." exception.

What is the current behavior?

Trying to bind an IEnumerable to a ListBox DataBinding throws an exception "Complex DataBinding accepts as a data source either an IList or an IListSource.".

What is the new behavior?

Replacing IEnumerable with IList allow the DataBinding.

What might this PR break?

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
Related to issue #531. I have also add a ApplicationHighDpiMode PerMonitorV2 in the project configuration to preserve scaling for high resolution monitors.

@rallets rallets mentioned this pull request Mar 16, 2022
@glennawatson glennawatson merged commit fb35f21 into reactiveui:main Mar 16, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants