housekeeping: Add Images to README.md #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 62.06% 62.06%
=======================================
Files 16 16
Lines 912 912
=======================================
Hits 566 566
Misses 346 346 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR adds two images showing how native validations may look like on Android and on desktops via
INotifyDataErrorInfo.What is the current behavior?
Currently, there are no images, and the benefits of using
ReactiveUI.Validation.AndroidXandiNotifyDataErrorInfoare unclear.What is the new behavior?
Now, the images are added, showing the native validation behavior on Android, and the validation behavior on desktop platforms via
INotifyDataErrorInfo. The images are taken from our cross-platform sample app, from LoginApp.Android and LoginApp.Avalonia projects.What might this PR break?
Nothing, this is just a minor README.md update.