feature: Add .NET 5 #170
Merged
feature: Add .NET 5 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.0 to 16.8.3. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.0...v16.8.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [DiffEngine](https://github.com/VerifyTests/DiffEngine) from 6.1.4 to 6.4.6. - [Release notes](https://github.com/VerifyTests/DiffEngine/releases) - [Commits](https://github.com/VerifyTests/DiffEngine/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [Microsoft.Reactive.Testing](https://github.com/dotnet/reactive) from 4.4.1 to 5.0.0. - [Release notes](https://github.com/dotnet/reactive/releases) - [Commits](dotnet/reactive@rxnet-v4.4.1...ixnet-v5.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
glennawatson
reviewed
Dec 9, 2020
glennawatson
requested changes
Dec 9, 2020
src/ReactiveUI.Validation.Tests/ReactiveUI.Validation.Tests.csproj
Outdated
Show resolved
Hide resolved
|
Planning to fix those nullability warnings tonight and refactor the code to comply with the updated NetAnalyzers rules. |
glennawatson
reviewed
Dec 9, 2020
|
Took the opportunity to remove |
glennawatson
reviewed
Dec 9, 2020
| @@ -39,7 +39,7 @@ | |||
| <ItemGroup> | |||
| <PackageReference Include="stylecop.analyzers" Version="1.2.0-beta.205" PrivateAssets="all" /> | |||
There was a problem hiding this comment.
stylecop.analyzers 1.2.0-beta.312 has a bunch of improvements for C# 9 if you want to bump that as well.
There was a problem hiding this comment.
Sorry for the multiple iterations of comments btw.
There was a problem hiding this comment.
No worries, and thanks for reviewing this! Going to bump that version as well soon.
glennawatson
approved these changes
Dec 9, 2020
Codecov Report
@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 62.36% 62.55% +0.19%
==========================================
Files 15 15
Lines 898 900 +2
==========================================
+ Hits 560 563 +3
+ Misses 338 337 -1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR adds .NET 5 support. Based on the diff. Planning to cherry-pick dependabot stuff also.