feature: Use ReactiveUI bindings in the Avalonia sample app #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR incorporates Avalonia.NameGenerator package that allows us to use ReactiveUI code-behind bindings and ReactiveUI.Validation bindings without writing any boilerplate code. This source generator generates strongly typed references to named Avalonia controls declared in XAML files, at compile time (almost like WPF or Windows.Forms do).
What is the current behavior?
We are mixing ReactiveUI markup bindings and code-behind bindings in
LoginApp.Avalonia.Also, we are writing
FindControlgetters by hand in the.xaml.csfile of our view class.What is the new behavior?
The bindings in our updated Avalonia sample app should look pretty concise now, and we no longer have to mix markup bindings and code-behind bindings.
What might this PR break?
Hopefully nothing, we are targeting .NET 5 anyway now.