Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos, add logo, add downloads badge to README #22

Merged
merged 1 commit into from
May 29, 2019

Conversation

worldbeater
Copy link
Collaborator

What kind of change does this PR introduce?

README.md file update.

What is the current behavior?

Currently there is a typo in the example, so mostly this PR is aimed to fix the following line:

// The property will create a new context each time it is accessed.
// This could cause issues if someone copy-pastes this line.
public ValidationContext ValidationContext => new ValidationContext();

What is the new behavior?

Fixed the typo, added shields downloads badge, added logo, added contributing section.

What might this PR break?

Nothing.

@worldbeater worldbeater requested a review from a team May 28, 2019 21:47
@glennawatson
Copy link
Collaborator

I will fix the build in a couple hours

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   34.98%   34.98%           
=======================================
  Files          16       16           
  Lines         706      706           
  Branches       82       82           
=======================================
  Hits          247      247           
  Misses        451      451           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c843ce...98a143d. Read the comment docs.

@glennawatson glennawatson merged commit 316b565 into master May 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the update-readme-logo-typos branch May 29, 2019 08:25
@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants