refactor: Remove unused generated templates #250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR removes the generated generic property validation classes that were reserved for future use. Since ReactiveUI.Validation now supports
IObservable<T>
-based validations (see #119), we are no longer planning to add extensions for those generic property validation classes, so removing the unused stuff might be reasonable.What is the current behavior?
Currently, there are legacy generated classes available as undocumented public API of the library.
What is the new behavior?
Now, the generated classes are removed.
What might this PR break?
Those apps that are relying on the undocumented generated APIs might break at compile-time. The migration to the documented and more flexible ReactiveUI.Validation
IObservable<T>
-based APIs should be quite simple though, as described inREADME.md
https://github.com/reactiveui/ReactiveUI.Validation#example