Added an analyzers, support for multiple validation and added Xamarin.Forms sample. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation for BasePropertyValidation classes.
…elObservableValidation.
…ments for ValidationContext.
…roved some LINQ queries too.
worldbeater
approved these changes
Mar 19, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
First of all, this PR includes comments on the whole solution alongside with minor LINQ improvements and custom IDisposable implementation following RxUI guidelines.
Furthermore, this PR includes a sample which is not finished at all, since I would like to make it "prettier" with a bunch of more uses for validations. This is the base case…
Finally, it also includes a bug fixing about supporting multiple validations in the View side.
What is the current behavior? (You can also link to an open issue here)
Multiple validations are not working properly from the View, but they do from the ValidationContext. To fix this, I added new Mixins which supports this feature.
The previous mixins will throw a custom exception indicating that multiple validations are not supported, enforcing to use the new mixins.
Link to the issue: #3
Please check if the PR fulfills these requirements