Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Update Samples #586

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix Update Samples #586

merged 1 commit into from
Nov 7, 2023

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Fix

What is the current behavior?

Samples are not building / not updateable

What is the new behavior?

Samples updated

What might this PR break?

None

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (786b9f1) 73.27% compared to head (a365763) 73.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #586   +/-   ##
=======================================
  Coverage   73.27%   73.27%           
=======================================
  Files          18       18           
  Lines         737      737           
  Branches      146      146           
=======================================
  Hits          540      540           
  Misses        119      119           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glennawatson glennawatson merged commit 7e4cf4d into main Nov 7, 2023
4 checks passed
@glennawatson glennawatson deleted the CP_FixSamples branch November 7, 2023 00:29
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants