Skip to content

Commit

Permalink
Fix: Dispose RxCommand having exceptions
Browse files Browse the repository at this point in the history
  • Loading branch information
glennawatson committed Jun 24, 2022
1 parent 80e4561 commit d24e69f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/ReactiveUI/ReactiveCommand/ReactiveCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -628,8 +628,10 @@ public class ReactiveCommand<TParam, TResult> : ReactiveCommandBase<TParam, TRes
{
private readonly IObservable<bool> _canExecute;
private readonly IDisposable _canExecuteSubscription;
[SuppressMessage("Design", "CA2213: Dispose member", Justification = "Internal use only")]
private readonly ScheduledSubject<Exception> _exceptions;
private readonly Func<TParam, IObservable<TResult>> _execute;
[SuppressMessage("Design", "CA2213: Dispose member", Justification = "Internal use only")]
private readonly Subject<ExecutionInfo> _executionInfo;
private readonly IObservable<bool> _isExecuting;
private readonly IScheduler _outputScheduler;
Expand Down Expand Up @@ -779,8 +781,6 @@ protected override void Dispose(bool disposing)
return;
}

_executionInfo.Dispose();
_exceptions.Dispose();
_canExecuteSubscription.Dispose();
}

Expand Down

0 comments on commit d24e69f

Please sign in to comment.