-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reactiveui-events not working for platform projects possibly related to PackageReference style projects #1526
Comments
|
@PureWeen Xamarin are working on official templates that use |
I pushed up another revision of my sample and you'll see a project called "FreshLonelyAndroidProject" that compiles fine Then if you add the "AzureDeviceClient" as a project reference to it it no longer compiles in v7 the dll was named ReactiveUI.Events_XamForms.dll where as v8 it's ReactiveUI.Events.dll which is the same name as the platform one. Are they colliding because of this? |
@PureWeen thx for the repro project. Confirming this was a bug which was caused by different event packages using the name assembly name. Resolved and new packages pushed to NuGet. |
Do you want to request a feature or report a bug?
bug
What is the current behavior?
I converted my projects all over to sdk style for shared projects and PackageReference for platform projects. After this was done (and compiling) I upgraded to the latest alpha bits of ReactiveUI and then all my ".events()" code stopped working
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
https://github.com/PureWeen/ReactiveUiEvents
Compile the SLN and see the errors
What is the expected behavior?
.Events() works in platform projects
What is the motivation / use case for changing the behavior?
.Events() works in platform projects
Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and development snapshot
Does not work in 8.0.0-alpha0105
Works in 7.4.0
Other information (e.g. stacktraces, related issues, suggestions how to fix)
The text was updated successfully, but these errors were encountered: