-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReactiveTableViewSource does not update Table View on changing data #1835
Comments
Here is the debug output from 8.7.2
And here from 9.0.1
Note the change in private void SectionInfoChanged(IReadOnlyList sectionInfo) in https://github.com/reactiveui/ReactiveUI/blob/master/src/ReactiveUI/Platforms/uikit-common/CommonReactiveSource.cs a853dea#diff-adf99e2de36e239f5fca78def0c29407L198 Previously:
Now:
|
…#1727) Make these streams more "visible" by exposing them from the adapter. Let the base adapter class do the work of merging the individual streams of each view holder, so the client doesn't have to.
Thanks for the detailed issue @OzerOzdemir I will work on this over the next day or so and see if I can get a solution for you. Will likely see if I can get a unit test up and running for this situation first and then provide a fix. |
@OzerOzdemir sorry it took so long, but got it working again. |
Verified that the is working now as expected. Much appreciated... |
Do you want to request a feature or report a bug?
This is a bug. It is a regression from 8.7.2 (working) to 9.0.1 (not working)
What is the current behavior?
ReactiveTableViewSource does not update the table view when the collection pointed at by "Data" gets modified.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
Here is a repro of the problem. This project was created on MacOS with Visual Studio for Mac.
https://1drv.ms/u/s!AKKNNcL3HxjfiOAZ
What is the expected behavior?
If a collection that implements INotifyCollectionChanged updates the collection, ReactiveTableViewSource is expected to update the cells in the UITableView.
What is the motivation / use case for changing the behavior?
Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and development snapshot
This is happening on the following configuration:
Other information (e.g. stacktraces, related issues, suggestions how to fix)
The text was updated successfully, but these errors were encountered: