Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dependency on Splat.Drawing #2342

Closed
michaelstonis opened this issue Feb 5, 2020 · 2 comments · Fixed by #2353
Closed

Remove Dependency on Splat.Drawing #2342

michaelstonis opened this issue Feb 5, 2020 · 2 comments · Fixed by #2353

Comments

@michaelstonis
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When the components of Splat.Drawing were created, they solved a very definite problem in the .NET ecosystem, especially on the Xamarin side of things. Now, we have a pretty good set of translation libraries on the Xamarin side (Xamarin.Essentials, etc.) and with other updates to .NET that open up the ability to share drawing primitives easily across platform.

Initializing Splat.Draw comes at a cost for something that I would imagine most users don't use and perhaps don't even really know exists. This appears to be especially true for Xamarin.Android which loads through all images in the bundle.

Describe the solution you'd like
Split it out so that Splat.Drawing is some kind of opt-in. Either, make it a separate package that only loads when included or make it a flag that can be enabled, if needed.

Describe alternatives you've considered
Perhaps keep things the way that they are more or less today, but make it so that it can be disabled. Right now everything there is statically registered, so it is always called and doesn't give a way to opt-out, so that portion would need to be updated.

@open-collective-bot
Copy link

open-collective-bot bot commented Feb 5, 2020

Hey @michaelstonis 👋,

Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider contributing financially.

https://opencollective.com/reactiveui

PS.: We offer priority support for all financial contributors. Don't forget to add priority label once you start contributing 😄

An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms!

@glennawatson
Copy link
Contributor

Sounds like a good fix to another bug reactiveui/splat#421

@lock lock bot added the outdated label Jun 24, 2020
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants