fix: Add HasRegistered check in InitializeReactiveUI for DI Containers. #2539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #2537
Allow registering custom services before calling InitializeReactiveUI by adding HasRegistration check.
This is mostly to allow cleaner substitution of custom services when using dependency inversion. You wouldn't need to unregister or have a redundant service registration anymore.
What is the current behavior?
Registers a service, without checking if a registration already exists.
What is the new behavior?
Now it checks, if a service with a certain type is already registered.
With this approach, one would register a custom service before the initialization call (like you currently do to override e.g. ILogger in InitializeSplat). Autofac DI is used in the example:
This means there aren't any redundant registrations, and no potential unexpected side-effects from that.
What might this PR break?
Nothing should brake.
Please check if the PR fulfills these requirements
Other information: