Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: add .DS_Store files to .gitignore #1368

Merged
merged 1 commit into from May 26, 2017

Conversation

Qonstrukt
Copy link
Member

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Make life easier for Mac users.

What is the current behavior? (You can also link to an open issue here)
.DS_Store files generated by macOS constantly screw up your git status.

What is the new behavior (if this is a feature change)?
Ignore .DS_Store files, since they're of no interest.

Does this PR introduce a breaking change?
Nope

Please check if the PR fulfills these requirements

Other information:

Copy link
Member

@ghuntley ghuntley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why this didn't exist before. Don't merge Qconstruct; I'll run you through the process when it goes green.

@ghuntley
Copy link
Member

ghuntley commented May 26, 2017

Alright here's the process, run through it and self merge.

https://docs.reactiveui.net/en/contributing/framework/merging-pull-requests.html

Specifically make sure you use squash and rebase commits and the commit message matches conventions.

eg...

housekeeping: added dsstore to gitignore

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.835% when pulling 1a361bb on Qonstrukt:dsstore-gitignore into cfbf11f on reactiveui:develop.

@Qonstrukt Qonstrukt added this to the vNext milestone May 26, 2017
@Qonstrukt Qonstrukt changed the title Add .DS_Store files to .gitignore housekeeping: add .DS_Store files to .gitignore May 26, 2017
@Qonstrukt Qonstrukt merged commit 9042eb2 into reactiveui:develop May 26, 2017
ghuntley pushed a commit that referenced this pull request Nov 6, 2017
housekeeping: add .DS_Store files to .gitignore
glennawatson pushed a commit that referenced this pull request Mar 23, 2019
housekeeping: add .DS_Store files to .gitignore
@lock lock bot locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants