Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: add ReactiveUI.LeakTest project #1527

Merged
merged 5 commits into from May 16, 2018

Conversation

GKotfis
Copy link
Contributor

@GKotfis GKotfis commented Oct 23, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature

What is the current behavior? (You can also link to an open issue here)

#1486

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 69.589% when pulling 9791742 on GKotfis:develop into f94ba3f on reactiveui:develop.

@ghuntley
Copy link
Member

ghuntley commented Nov 7, 2017

Thank-you @GKotfis for picking this up!

Great initial progress, next steps are to integrate this into the CI pipeline by updating build.cake to execute this new unit test assembly. I'm happy to merge this PR as-is right now or you can keep building upon this one.

image

@ghuntley ghuntley changed the title Add ReactiveUI.LeakTest project housekeeping: add ReactiveUI.LeakTest project Nov 7, 2017
@reactiveui reactiveui deleted a comment from dnfclas Dec 7, 2017
@ghuntley ghuntley changed the base branch from develop to master May 16, 2018 11:30
@ghuntley ghuntley requested a review from a team May 16, 2018 11:30
@GKotfis GKotfis requested a review from a team May 16, 2018 13:02
Copy link
Member

@ghuntley ghuntley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank-you for sending this in @GKotfis. Apologies this took so long to review - we have made some changes to make sure it doesn't happen again. If you're still keen on helping out come join us in https://reactiveui.net/slack in the #reactiveui-succession channel.

@ghuntley ghuntley merged commit 730b44e into reactiveui:master May 16, 2018
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants