fix: Fix UWP activating too soon #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elipriaulx
approved these changes
Jan 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #1930 +/- ##
======================================
Coverage 64.4% 64.4%
======================================
Files 99 99
Lines 3574 3574
Branches 899 899
======================================
Hits 2302 2302
Misses 1140 1140
Partials 132 132
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UWP had special logic where it would use loading instead of Load for performance reasons, and then wait for IsHitTestVisible. This would cause problems with certain use cases in WPF.
Now splitting the two ActivationForViewFetcher class into their own classes with the required logic.
This fixes #1928