Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BindCommand unhandled exceptions don't fire on Xamarin Android #2043

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
1 participant
@glennawatson
Copy link
Contributor

commented May 21, 2019

Fixes #1859 where the android bind command will swallow exceptions.

@glennawatson glennawatson requested a review from reactiveui/android-team as a code owner May 21, 2019

@codecov

This comment has been minimized.

Copy link

commented May 21, 2019

Codecov Report

Merging #2043 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2043   +/-   ##
======================================
  Coverage    60.2%   60.2%           
======================================
  Files         116     116           
  Lines        4453    4453           
  Branches      639     639           
======================================
  Hits         2681    2681           
  Misses       1600    1600           
  Partials      172     172

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec9946...a1b77fe. Read the comment docs.

@glennawatson glennawatson changed the title fix: BindCommand unhandled excpetions don't fire on Xamarin Android fix: BindCommand unhandled exceptions don't fire on Xamarin Android May 21, 2019

@glennawatson glennawatson merged commit fd9df6b into master May 21, 2019

6 checks passed

ReactiveUI-CI Build #9.15.8+13ae581233 succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
codecov/patch Coverage not affected when comparing fec9946...a1b77fe
Details
codecov/project 60.2% remains the same compared to fec9946
Details
license/cla All CLA requirements met.

@delete-merged-branch delete-merged-branch bot deleted the issue-1859 branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.