fix: BindCommand unhandled exceptions don't fire on Xamarin Android #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2043 +/- ##
======================================
Coverage 60.2% 60.2%
======================================
Files 116 116
Lines 4453 4453
Branches 639 639
======================================
Hits 2681 2681
Misses 1600 1600
Partials 172 172Continue to review full report at Codecov.
|
glennawatson
changed the title
madmonkey
pushed a commit
to madmonkey/ReactiveUI
that referenced
this pull request
Jul 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1859 where the android bind command will swallow exceptions.