Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for WhenAnyValue now returns non nullable type #2808

Merged
merged 3 commits into from Jun 28, 2021

Conversation

ChrisPulman
Copy link
Member

fix #2806
Remove nullable return value from WhenAnyValue

What kind of change does this PR introduce?

fix

What is the current behaviour?

WhenAnyValue has a return type of T?

What is the new behaviour?

WhenAnyValue has a return type of T

What might this PR break?

None

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

fix #2806
Remove nullable return value from WhenAnyValue
@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #2808 (39b5af6) into main (b2e9db9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2808   +/-   ##
=======================================
  Coverage   64.47%   64.47%           
=======================================
  Files         134      134           
  Lines        4712     4712           
=======================================
  Hits         3038     3038           
  Misses       1674     1674           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e9db9...39b5af6. Read the comment docs.

@glennawatson glennawatson merged commit 32d2838 into main Jun 28, 2021
@glennawatson glennawatson deleted the fix_WhenAnyValue_RemoveNullableReturnValue branch June 28, 2021 09:01
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unnecessary nullable in .Select() in 14.1.1
2 participants