Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2811 Updated nullable values for OAPH #2813

Merged
merged 1 commit into from Jun 29, 2021

Conversation

ChrisPulman
Copy link
Member

fixes #2811 can pass nullable in but return type is not forced to nullable

What kind of change does this PR introduce?

fix

What is the current behaviour?

OAPH returns a nullable type regardless of the OAPH it is attached to

What is the new behaviour?

OAPH returns a matching type of the OAPH it is attached to

What might this PR break?

none

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

fix #2811 can pass nullable in but return type is not forced to nullable
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #2813 (d6af992) into main (32d2838) will increase coverage by 0.57%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2813      +/-   ##
==========================================
+ Coverage   64.47%   65.04%   +0.57%     
==========================================
  Files         134      134              
  Lines        4712     4712              
==========================================
+ Hits         3038     3065      +27     
+ Misses       1674     1647      -27     
Impacted Files Coverage Δ
...eUI.Fody.Helpers/ObservableAsPropertyExtensions.cs 41.93% <ø> (ø)
...ObservableForProperty/INPCObservableForProperty.cs 86.48% <60.00%> (ø)
...iveUI/Mixins/ReactiveNotifyPropertyChangedMixin.cs 83.33% <100.00%> (ø)
...I/ObservableForProperty/OAPHCreationHelperMixin.cs 38.40% <100.00%> (ø)
...bservableForProperty/ObservableAsPropertyHelper.cs 94.11% <100.00%> (ø)
src/ReactiveUI/VariadicTemplates.cs 52.36% <0.00%> (+6.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d2838...d6af992. Read the comment docs.

@glennawatson glennawatson merged commit 806d1fe into main Jun 29, 2021
@glennawatson glennawatson deleted the fix_OAPH_Nullabe_types branch June 29, 2021 07:30
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] OAPH nullability as a result of 2762
2 participants