Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Transitioning Content Control DPI issue #2827

Merged
merged 1 commit into from Jul 12, 2021

Conversation

ChrisPulman
Copy link
Member

@ChrisPulman ChrisPulman commented Jul 12, 2021

RenderTargetBitmap take an int therefore the minimum input value must be 1.

What kind of change does this PR introduce?

fix #2801

What is the current behaviour?

Transitioning Content Control has a DPI issue with a calculation returning less than 1;

What is the new behaviour?

Transitioning Content Control handles DPI issue with a calculation returning less than 1 but being resolved to 1;

What might this PR break?

none as is only used for animation.

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

RenderTargetBitmap take an int therefore the minimum input value must be 1.
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #2827 (075f60b) into main (de9557f) will increase coverage by 1.72%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2827      +/-   ##
==========================================
+ Coverage   68.28%   70.01%   +1.72%     
==========================================
  Files         137      137              
  Lines        4787     4792       +5     
==========================================
+ Hits         3269     3355      +86     
+ Misses       1518     1437      -81     
Impacted Files Coverage Δ
src/ReactiveUI.Wpf/TransitioningContentControl.cs 58.23% <100.00%> (+45.50%) ⬆️
src/ReactiveUI.Wpf/ReactiveWindow.cs 72.72% <0.00%> (+72.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9557f...075f60b. Read the comment docs.

@glennawatson glennawatson merged commit 663110c into main Jul 12, 2021
@glennawatson glennawatson deleted the fix_WPF_TransitioningContentControl branch July 12, 2021 23:44
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransitionContentControl throwing exception on control width almost zero
2 participants