New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix IsExecuting and Can Execute threading issue #2835
fix IsExecuting and Can Execute threading issue #2835
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2835 +/- ##
==========================================
+ Coverage 71.50% 71.81% +0.30%
==========================================
Files 137 137
Lines 4804 4828 +24
==========================================
+ Hits 3435 3467 +32
+ Misses 1369 1361 -8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to be configurable
users should recheck their code to ensure correct operation and set the canExecuteScheduler as required.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
fix #2834
What is the current behaviour?
Executing fails if a TaskPool thread is selected
What is the new behaviour?
Executing works if a TaskPool thread is selected
What might this PR break?
none expected
Please check if the PR fulfils these requirements
Other information: