Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Command Scheduler not set to immediate where required for CanExecute #2849

Merged
merged 2 commits into from Aug 3, 2021

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

fix

What is the current behaviour?

Tests do not pass

What is the new behaviour?

Tests now pass

What might this PR break?

N/A

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Jul 31, 2021

Codecov Report

Merging #2849 (c287849) into main (77e217d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2849   +/-   ##
=======================================
  Coverage   71.83%   71.83%           
=======================================
  Files         137      137           
  Lines        4828     4828           
=======================================
  Hits         3468     3468           
  Misses       1360     1360           
Impacted Files Coverage Δ
.../ReactiveUI/ReactiveCommand/ReactiveCommandBase.cs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e217d...c287849. Read the comment docs.

@ChrisPulman ChrisPulman enabled auto-merge (squash) July 31, 2021 16:15
@ChrisPulman ChrisPulman merged commit 18983a5 into main Aug 3, 2021
@ChrisPulman ChrisPulman deleted the fix_RxAppTest_wrongScheduler branch August 3, 2021 12:21
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants