Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak on WPF #2986

Merged
merged 5 commits into from
Oct 30, 2021
Merged

fix: memory leak on WPF #2986

merged 5 commits into from
Oct 30, 2021

Conversation

glennawatson
Copy link
Contributor

@glennawatson glennawatson commented Oct 30, 2021

What kind of change does this PR introduce?

fixes #2935

What is the current behavior?

There is a memory leak introduced in #2793

What is the new behavior?

Remove the dispatcher object hook to prevent the memory leak.

What might this PR break?

Users relying on the dispatcher closing, but this will cause a memory leak which is the greater evil.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #2986 (72004d8) into main (aa50420) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
- Coverage   72.20%   72.14%   -0.07%     
==========================================
  Files         140      140              
  Lines        4904     4893      -11     
==========================================
- Hits         3541     3530      -11     
  Misses       1363     1363              
Impacted Files Coverage Δ
src/ReactiveUI.Wpf/ActivationForViewFetcher.cs 97.72% <ø> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa50420...72004d8. Read the comment docs.

@glennawatson glennawatson merged commit a43e99a into main Oct 30, 2021
@glennawatson glennawatson deleted the glennawatson-patch-1 branch October 30, 2021 08:24
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Memory leak without disposing 'WhenActivated' returned value
1 participant