Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize null filtering #3323

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Optimize null filtering #3323

merged 1 commit into from
Jul 24, 2022

Conversation

adamradocz
Copy link
Contributor

Null was filtered twice.

What kind of change does this PR introduce?

Optimization.

What is the current behavior?

The viewModelChanged checked the null twice.

What is the new behavior?

Filters only once.

Other information:

The new version of #3319. That cannot be updated because its branch was deleted.

Null was filtered twice.
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #3323 (bd97de9) into main (f6aa117) will decrease coverage by 0.22%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #3323      +/-   ##
==========================================
- Coverage   63.83%   63.60%   -0.23%     
==========================================
  Files         157      157              
  Lines        5726     5768      +42     
==========================================
+ Hits         3655     3669      +14     
- Misses       2071     2099      +28     
Impacted Files Coverage Δ
...ngs/Converter/NullableLongToStringTypeConverter.cs 12.50% <0.00%> (-4.17%) ⬇️
...ngs/Converter/NullableByteToStringTypeConverter.cs 66.66% <33.33%> (-11.12%) ⬇️
.../Converter/NullableDecimalToStringTypeConverter.cs 62.96% <33.33%> (-8.47%) ⬇️
...s/Converter/NullableDoubleToStringTypeConverter.cs 62.96% <33.33%> (-8.47%) ⬇️
...gs/Converter/NullableShortToStringTypeConverter.cs 66.66% <33.33%> (-11.12%) ⬇️
...s/Converter/NullableSingleToStringTypeConverter.cs 62.96% <33.33%> (-8.47%) ⬇️
.../Converter/NullableIntegerToStringTypeConverter.cs 79.16% <66.66%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b5ddc...bd97de9. Read the comment docs.

@glennawatson glennawatson merged commit 03f4c95 into reactiveui:main Jul 24, 2022
@adamradocz adamradocz deleted the OptimizeNullFilteringInBlazor branch July 24, 2022 12:43
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants