Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Disposables not disposed in test #3385

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

FIx

What is the current behaviour?

Test failing to build

What is the new behaviour?

Fixed issue with build

What might this PR break?

none

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@ChrisPulman ChrisPulman enabled auto-merge (squash) October 19, 2022 06:06
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 63.60% // Head: 63.60% // No change to project coverage 👍

Coverage data is based on head (598dbad) compared to base (eebbacf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3385   +/-   ##
=======================================
  Coverage   63.60%   63.60%           
=======================================
  Files         157      157           
  Lines        5768     5768           
=======================================
  Hits         3669     3669           
  Misses       2099     2099           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChrisPulman ChrisPulman merged commit e45982e into main Oct 20, 2022
@ChrisPulman ChrisPulman deleted the CP_FixTest_Disposables branch October 20, 2022 08:02
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants