Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feature to MAUI #3475

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Feature

What is the current behaviour?

No Reactive version of Shell or ShellContent exists in MAUI

What is the new behaviour?

Add Feature ReactiveShell
Add Feature ReactiveShellContent
Update Blazor packages
Update AndriodX packages

What might this PR break?

Non expected

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Add ReactiveShell
Add ReactiveShellContent
Update Blazor packages
Update AndriodX packages
@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Base: 64.82% // Head: 63.60% // Decreases project coverage by -1.22% ⚠️

Coverage data is based on head (a9743b0) compared to base (09fd3e6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3475      +/-   ##
==========================================
- Coverage   64.82%   63.60%   -1.22%     
==========================================
  Files         155      157       +2     
  Lines        5660     5768     +108     
==========================================
  Hits         3669     3669              
- Misses       1991     2099     +108     
Impacted Files Coverage Δ
.../ReactiveUI.Uwp/Rx/Concurrency/ControlScheduler.cs 0.00% <0.00%> (ø)
src/ReactiveUI.Uwp/Rx/Linq/ControlObservable.cs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChrisPulman
Copy link
Member Author

Decrease in coverage is due to code from Uwp which we have retired, some of the code is still being used by some projects, but we should do a run on increasing the test coverage again aiming get it closer to 80%.

@glennawatson glennawatson merged commit 17ab166 into main Feb 18, 2023
@glennawatson glennawatson deleted the Feature_Maui_ReactiveShell_ReactiveShellContent branch February 18, 2023 17:49
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants