Fix issue in ReactiveUI.Wpf when windows10.0.19041 is selected at runtime by end user #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #3493 Added 19041 target as a workaround for System.Reactive targeting net5.0-windows10.0.19041.0 When 19041 is selected by the end user it causes the DispatcherScheduler in System.Reactive to be exposed and used.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3494 +/- ##
==========================================
- Coverage 63.83% 63.60% -0.23%
==========================================
Files 157 157
Lines 5768 5768
==========================================
- Hits 3682 3669 -13
- Misses 2086 2099 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix for #3493
What is the current behaviour?
Works on all targets except windows10.0.19041
What is the new behaviour?
Works on all targets
Added windows10.0.19041.0 target as a workaround for System.Reactive targeting net5.0-windows10.0.19041.0
When windows10.0.19041.0 is selected by the end user it causes the DispatcherScheduler in System.Reactive to be exposed and used.
What might this PR break?
none expected
Please check if the PR fulfils these requirements
Other information: