Housekeeping: Update Obsolete notation to fix warnings #3561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set ObserveOnDispatcher() as Obsolete in favour of ObserveOn(RxApp.MainThreadScheduler) Add Targets for Net7.0 to ReactiveUI.Drawing remove DispatcherScheduler from WinForms update dependency packages fix warnings from analysers
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3561 +/- ##
==========================================
+ Coverage 63.91% 64.68% +0.77%
==========================================
Files 157 157
Lines 5783 5762 -21
==========================================
+ Hits 3696 3727 +31
+ Misses 2087 2035 -52
☔ View full report in Codecov by Sentry. |
Test added, ViewModelViewHost test is not possible due to deliberate exclusion from tests
Update cohesion
Add EnforceExtendedAnalyzerRules as per recommendations
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix Obsolete warnings
Update code to remove warnings
What is the current behaviour?
many warnings exist for Obsolete code in Android targets
other warnings exist from running analysers
What is the new behaviour?
Set ObserveOnDispatcher() as Obsolete in favour of ObserveOn(RxApp.MainThreadScheduler) in WPF
Add Targets for Net7.0 to ReactiveUI.Drawing
remove DispatcherScheduler from WinForms
update dependency packages some are missed by dependabot
fix warnings from analysers
What might this PR break?
None expected
Please check if the PR fulfils these requirements
Other information:
Test added, ViewModelViewHost test is not possible due to deliberate exclusion from tests