Update WhenAnyObservable to allow null sender #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3573 +/- ##
=======================================
Coverage 63.91% 63.91%
=======================================
Files 157 157
Lines 5783 5783
=======================================
Hits 3696 3696
Misses 2087 2087
☔ View full report in Codecov by Sentry. |
glennawatson
approved these changes
Jul 8, 2023
Seems to be a new check in VS2022 for resolving net 5.x+ dependencies where previously would have failed over to NetFramework 4.x
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix for #3343
What is the current behavior?
WhenAnyObservable sender cannot be nullable
What is the new behavior?
WhenAnyObservable sender can now be nullable
What might this PR break?
none expected
Please check if the PR fulfills these requirements
Other information: