Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix For ViewModelViewHost not working on WinUI projects #3575

Merged

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Fix for #3248

What is the current behaviour?

ViewModelViewHost not working on WinUI projects.

What is the new behaviour?

Updated namespace to allow to work

What might this PR break?

none expected

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@ChrisPulman ChrisPulman linked an issue Jul 8, 2023 that may be closed by this pull request
@anaisbetts
Copy link
Member

Seems good but make sure this doesn't break any other platform!

@glennawatson
Copy link
Contributor

Seems good but make sure this doesn't break any other platform!

It's the one in the Maui project folder so won't affect anything else.

@ChrisPulman
Copy link
Member Author

Seems good but make sure this doesn't break any other platform!

This would have been an issue on Maui-WinUI and WinUI as was in the same assembly, strangely the XAML Parser does not link it when you specify the same assembly. The Uwp base code that was in use previously has been moved into Maui to allow specific WinUI/Maui code changes, the intention is to remove the Uwp project folder in the near future.

@ChrisPulman ChrisPulman merged commit 2ef3d99 into main Jul 8, 2023
1 check passed
@ChrisPulman ChrisPulman deleted the winui-viewmodelviewhost-not-working-on-winui-projects branch July 8, 2023 09:41
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][WinUI]: ViewModelViewHost not working on WinUI projects.
3 participants