Update : Remove Requirements for the Latest WinUI SDK in Maui #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing the latest SDK we will automatically fall back to our target framework 19041 this will ensure that we dont use components that are not compatible with older versions of windows 10 whilst enabling the end user a simple means of using the library with the SDK automatically being by the IDE selecting the correct SDK based upon the end users Target choices
ChrisPulman
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
=======================================
Coverage 64.07% 64.07%
=======================================
Files 157 157
Lines 5762 5762
=======================================
Hits 3692 3692
Misses 2070 2070 ☔ View full report in Codecov by Sentry. |
glennawatson
approved these changes
Jul 9, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update
What is the current behaviour?
There is a possibility that we could use functionality that is not available on the end users target by importing a newer SDK than the target we use.
What is the new behaviour?
By removing the latest SDK we will automatically fall back to our target framework 19041 this will ensure that we don't use components that are not compatible with older versions of windows 10 whilst enabling the end user a simple means of using the library with the SDK automatically being by the IDE selecting the correct SDK based upon the end users Target choices
What might this PR break?
None expected, those who have already added the newer SDK's can continue to do so
Please check if the PR fulfils these requirements
Other information: