breaking: Add a interface to IInteraction #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the interface GetOutput() is no longer accessible. This enforces strict requirements
RLittlesII
approved these changes
Jul 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3586 +/- ##
=======================================
Coverage 64.00% 64.00%
=======================================
Files 157 157
Lines 5750 5748 -2
=======================================
- Hits 3680 3679 -1
+ Misses 2070 2069 -1
☔ View full report in Codecov by Sentry. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the interface
IInteractionContexttheGetOutput()is no longer accessible. You can still cast the concrete class. This enforces strict requirementsSince
Interactiongenerated theInteractionContextthere should be minimal changes to users unless they useGetOutputon the context. TheGetOutputis on another interface used internally to get the output value.There is now support for providing your own context's by overriding the protected method
GenerateContexton theInteractionclass.