Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Test Sequencer #3587

Merged
merged 3 commits into from Jul 16, 2023
Merged

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Feature
Fix Tests updated to help stop build errors.

What is the current behaviour?

Tests fail randomly due to a timing issue between test runs

What is the new behaviour?

Updated tests to add schedulers and to add Test Sequencer where required to help ensure tests don't finish randomly.

What might this PR break?

None Only tests affected, ReactiveUI.Testing has a new feature.

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Update tests to add schedulers and to add Test Sequencer where required to help ensure tests don't finish randomly.
Remove Expected phase due to intermittent issue
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Patch coverage: 97.77% and project coverage change: +0.07 🎉

Comparison is base (178abac) 64.00% compared to head (75e39a9) 64.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3587      +/-   ##
==========================================
+ Coverage   64.00%   64.07%   +0.07%     
==========================================
  Files         157      158       +1     
  Lines        5750     5762      +12     
==========================================
+ Hits         3680     3692      +12     
  Misses       2070     2070              
Impacted Files Coverage Δ
src/ReactiveUI/Interactions/InteractionContext.cs 100.00% <ø> (ø)
src/ReactiveUI/Interactions/Interaction.cs 97.77% <94.73%> (-0.05%) ⬇️
src/ReactiveUI.Testing/TestSequencer.cs 100.00% <100.00%> (ø)
...ngs/Interaction/InteractionBinderImplementation.cs 83.33% <100.00%> (ø)
...I/Bindings/Interaction/InteractionBindingMixins.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glennawatson glennawatson merged commit 3ede17e into main Jul 16, 2023
3 checks passed
@glennawatson glennawatson deleted the CP_AddTestSequencerUpdateTests branch July 16, 2023 00:11
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants