Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set content to default if unable to resolve view with view locator #359

Merged
merged 2 commits into from
Aug 14, 2013

Conversation

terenced
Copy link
Contributor

@terenced terenced commented Aug 1, 2013

Handle case where ViewLocator is configured incorrectly, and returns a null view.
If view is null, content is set to default content.

related to #357

@anaisbetts
Copy link
Member

I actually think this is a bad idea, it hides the true cause of a common bug. Thoughts?

@terenced
Copy link
Contributor Author

terenced commented Aug 7, 2013

Perhaps we should throw a more meaningful exception?
"Unable able to resolve view for view model 'NameOfViewModel'"

@anaisbetts
Copy link
Member

@terenced Much better idea I think

anaisbetts pushed a commit that referenced this pull request Aug 14, 2013
Set content to default if unable to resolve view with view locator
@anaisbetts anaisbetts merged commit 5dce7c4 into reactiveui:master Aug 14, 2013
@anaisbetts
Copy link
Member

@terenced Sorry for the delay - thanks for the PR!

@lock lock bot locked and limited conversation to collaborators Jun 26, 2019
@terenced terenced deleted the handle-unresolved-view branch April 10, 2023 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants