New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking change: Make Bind use non-generic IViewFor #3676
Conversation
Add BindCommandNonGeneric this is too avoid the request of not changing the existing code, therefore adding to the available options. NOTE: Bind only requires `IViewFor` and `IViewFor<TViewModel>` inherits `IViewFor` therefore would still be a non breaking change if BindCommand were relaxed to IViewFor. add ReactiveUserControlNonGeneric for WinForms
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3676 +/- ##
==========================================
- Coverage 58.49% 57.90% -0.60%
==========================================
Files 158 160 +2
Lines 5775 5822 +47
Branches 1026 1034 +8
==========================================
- Hits 3378 3371 -7
- Misses 2010 2063 +53
- Partials 387 388 +1 ☔ View full report in Codecov by Sentry. |
This reverts commit 246e8ef.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
Fix for #3644
What is the current behavior?
BindCommand requires a view inherited from
IViewFor<TViewModel>
ReactiveUserControl inherits
IViewFor<TViewModel>
which requires Generics which WinForms does not work well with.What is the new behavior?
Add BindCommandNonGeneric this is to avoid the request of not changing the existing code, therefore adding to the available options.
NOTE: Bind only requires
IViewFor
andIViewFor<TViewModel>
inheritsIViewFor
therefore would still be an API change if BindCommand were relaxed to IViewFor in the same way as Bind, but perhaps the best route.add ReactiveUserControlNonGeneric for WinForms - inherits
IViewFor
What might this PR break?
Non due to new functions
Please check if the PR fulfills these requirements
Other information: