Fix MAUI RoutedViewHost Navigation

[idotta]

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

#3640 When 'RoutedViewHost' is activated, it calls 'SyncNavigationStacksAsync', which pushes a page for the current ViewModel. However, the Router.Navigate subscription is also triggered, creating and pushing a new page for the same ViewModel.

What is the new behavior?

To fix this, I filtered Navigate to execute the action only when the NavigationStacks have different sizes, since it seems that is what the Navigate subscription was supposed to do anyway. I think this makes the subsequent call to SyncNavigationStacksAsync() useless. Should I remove it?

What might this PR break?
RoutedViewHost Navigate subscription.

Please check if the PR fulfills these requirements

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

Other information:
I was informed that there were no tests for MAUI and no documentation seemed to be present either.

[glennawatson]

Give me a day to read through all this and test etc.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f533f16) 58.38% compared to head (2560b63) 58.98%.

❗ Current head 2560b63 differs from pull request most recent head 2028d07. Consider uploading reports for the commit 2028d07 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3692      +/-   ##
==========================================
+ Coverage   58.38%   58.98%   +0.60%     
==========================================
  Files         160      160              
  Lines        5774     5774              
  Branches     1028     1028              
==========================================
+ Hits         3371     3406      +35     
+ Misses       2015     1980      -35     
  Partials      388      388              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[glennawatson]

Documentation is under https://github.com/reactiveui/website repo. At least user facing documentation. XML and inline comments used in the c# code

GitHub

GitHub - reactiveui/website: ReactiveUI documentation and guidelines website. PR's welcome! 💖

ReactiveUI documentation and guidelines website. PR's welcome! 💖 - GitHub - reactiveui/website: ReactiveUI documentation and guidelines website. PR's welcome! 💖

[idotta]

Thank you for being so patient. I mentioned the documentation because I didn't know if there was anything I should add (just following the PR script). Maybe I didn't express myself very well.

[glennawatson]

Alright done some basic checks. Seems alright. Will merge it in. I think we are waiting on a dynamicdata release before releasing the next version of the software.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.