Feature enable Net 8.0 on WinUI #3701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3701 +/- ##
=======================================
Coverage 58.37% 58.37%
=======================================
Files 160 160
Lines 5776 5776
Branches 1029 1029
=======================================
Hits 3372 3372
Misses 2015 2015
Partials 389 389 ☔ View full report in Codecov by Sentry. |
dpvreony
approved these changes
Dec 31, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
WinUI has net 6.0 and net 7.0 builds
What is the new behavior?
ReacitveUI.WinUI now includes a build for net 8.0
What might this PR break?
Target framework needs to be updated to windows10.0.19041.0 if using an earlier version.
Please check if the PR fulfills these requirements
Other information: