Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping - Update usings and namespaces #3702

Merged
merged 3 commits into from Dec 31, 2023
Merged

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Housekeeping

What is the current behavior?

unused usings exist
namespaces for maui using base ReactiveUI namespace

What is the new behavior?

unused usings removed
namespaces for ReactiveUI.Maui updated
API packages updated and test amended as necessary - NO API actually changed, pure formatting update.

What might this PR break?

XAML includes using the ReactiveUI namespace will need to update to ReactiveUI.Maui to standardise across all controls.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bfc9a04) 58.37% compared to head (2b6b0e4) 59.00%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/ReactiveUI/Mixins/DependencyResolverMixins.cs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3702      +/-   ##
==========================================
+ Coverage   58.37%   59.00%   +0.62%     
==========================================
  Files         160      160              
  Lines        5776     5776              
  Branches     1029     1029              
==========================================
+ Hits         3372     3408      +36     
+ Misses       2015     1979      -36     
  Partials      389      389              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman enabled auto-merge (squash) December 31, 2023 21:16
@ChrisPulman ChrisPulman enabled auto-merge (squash) December 31, 2023 21:25
@ChrisPulman ChrisPulman merged commit 2d7801e into main Dec 31, 2023
1 check passed
@ChrisPulman ChrisPulman deleted the CP_Housekeeping branch December 31, 2023 21:29
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants