Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Implemented basic command binding support for Android View derived cla... #371

Merged
merged 2 commits into from
Oct 3, 2013

Conversation

oliverw
Copy link
Contributor

@oliverw oliverw commented Aug 28, 2013

...sses

  • Bumped Android Target Framework to 15 since there are pretty much no vanilla 4.0 out in the wild

@anaisbetts
Copy link
Member

🆒 - any way you can move FlexibleCommandBinder up a directory so that it's not duped?

@oliverw
Copy link
Contributor Author

oliverw commented Aug 28, 2013

Sure

--Oliver WeichholdSenior Consultant

Date: Wed, 28 Aug 2013 05:45:49 -0700
From: notifications@github.com
To: ReactiveUI@noreply.github.com
CC: oliver@weichhold.com
Subject: Re: [ReactiveUI] - Implemented basic command binding support for Android View derived cla... (#371)

  • any way you can move FlexibleCommandBinder up a directory so that it's not duped?


Reply to this email directly or view it on GitHub.

{
public class AndroidCommandBinders : FlexibleCommandBinder
{
public static Lazy<AndroidCommandBinders> Instance = new Lazy<AndroidCommandBinders>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be readonly?

…classes

- Bumped Android Target Framework to 15 since there are pretty much no vanilla 4.0 out in the wild

Conflicts:
	ReactiveUI.Events/Resources/Resource.Designer.cs
@anaisbetts
Copy link
Member

I had to force-push to get this updated, sorry about that.

@anaisbetts
Copy link
Member

LETS DO IT

anaisbetts pushed a commit that referenced this pull request Oct 3, 2013
- Implemented basic command binding support for Android View derived cla...
@anaisbetts anaisbetts merged commit 66ddf3f into master Oct 3, 2013
@anaisbetts
Copy link
Member

Thanks @oliverw!

@anaisbetts anaisbetts deleted the android-binding-improvements branch December 16, 2013 02:19
@lock lock bot locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants